sata_mv kernel bug in 4.11.x FIXED in >= 4.11.3-2

This forum is for Marvell Kirkwood devices such as the GoFlex Home/Net, PogoPlug v1/v2, SheevaPlug, and ZyXEL devices.

sata_mv kernel bug in 4.11.x FIXED in >= 4.11.3-2

Postby sakaki » Mon Jun 05, 2017 11:06 am

Hello,

recently I had a few emails from users of my Arch Linux live USB for the B3 (a Kirkwood-based miniserver), noting that they were unable to boot after upgrading their linux-kirkwood-dt to 4.11.3-1. The issue was that the sata driver was failing to start, so the kernel was failing to see the HDD. Here's a snippet from the serial port trace:
Code: Select all
[    0.828904] sata_mv f1080000.sata: version 1.28
[    0.828922] sata_mv f1080000.sata: can't request region for resource
[mem 0xf1080000-0xf1084fff]
[    0.837773] sata_mv: probe of f1080000.sata failed with error -16


I bisected this to commit 368e5fbdfc60 in the kernel tree, and emailed the commit owner, Andy Shevchenko. He has today kindly pointed me to a fix in the upstream, which reverts commit 368e5fbdfc60. Revert commit message reads:
Code: Select all
Revert "ata: sata_mv: Convert to devm_ioremap_resource()"

This reverts commit 368e5fbdfc60732643f34f538823ed4bc8829827.

devm_ioremap_resource() enforces that there are no overlapping
resources, where as devm_ioremap() does not. The sata phy driver needs
a subset of the sata IO address space, so maps some of the sata
address space. As a result, sata_mv now fails to probe, reporting it
cannot get its resources, and so we don't have any SATA disks.

Signed-off-by: Andrew Lunn <andrew@lunn.ch>
Acked-by: Gregory CLEMENT <gregory.clement@free-electrons.com>
Cc: stable@vger.kernel.org # v4.11+
Signed-off-by: Tejun Heo <tj@kernel.org>


Given that 368e5fbdfc60 prevents the sata drivers from starting on at least the B3, and possibly other Kirkwood devices as well, with the currently shipping Arch kernel, would it be possible to revert 368e5fbdfc60 via a patch, until the fix is merged into the mainline?

Many thanks, sakaki
Last edited by sakaki on Tue Jun 06, 2017 10:28 am, edited 1 time in total.
sakaki
 
Posts: 9
Joined: Sat Mar 28, 2015 1:53 pm

Re: Confirmed sata_mv kernel bug in 4.11.x / 4.12.x

Postby planeteater » Mon Jun 05, 2017 12:54 pm

planeteater
 
Posts: 21
Joined: Sat Dec 29, 2012 2:44 pm

sata_mv kernel bug in 4.11.x FIXED in >= 4.11.3-2

Postby sakaki » Tue Jun 06, 2017 10:27 am

OK, many thanks!
Case of crossed wires - I started looking into this before 4.11.3-2 came out ><
Best, sakaki
sakaki
 
Posts: 9
Joined: Sat Mar 28, 2015 1:53 pm


Return to Marvell Kirkwood

Who is online

Users browsing this forum: No registered users and 3 guests