[SOLVED] Pull Request Question

This forum is for discussion about general software issues.

[SOLVED] Pull Request Question

Postby calzon65 » Thu Jul 17, 2014 10:01 pm

I have worked with the maintainer of a package in the upstream ArchLinux AUR to correct some dependency problems and update to the latest upstream version of the source in his PKGBUILD file. An older version of the package is currently in our github package database in the aur folder.

I am very sorry to have to post this question, but I want to get this right the first time. Reading the notes about contributing, I believe the next step I need to take is to submit a Pull Request with the applicable information about the package. Since an older version of the package is already in the ArchLinux ARM github, is it my responsibility to pull down the updated PKBUILD and other related files in the package's tarball, or is that handled by the ArchLinux ARM devs who then update the github?
Last edited by calzon65 on Fri Jul 18, 2014 11:14 pm, edited 1 time in total.
calzon65
 
Posts: 80
Joined: Wed May 25, 2011 9:06 pm

Re: Pull Request Question

Postby WarheadsSE » Thu Jul 17, 2014 11:37 pm

If you wouldn't mind actually taking care of said updated AUR package, that would be nice.
Core Developer
Remember: Arch Linux ARM is entirely community donation supported!
WarheadsSE
Developer
 
Posts: 6807
Joined: Mon Oct 18, 2010 2:12 pm

Re: Pull Request Question

Postby calzon65 » Fri Jul 18, 2014 4:22 am

I have no experience with GitHub, but I gave it a try. I installed GitHub for windows, I think I created a sync of the Alarm github repository (at least I see a duplicate files structure and files on my system), I downloaded the updated PKGBUILD from the AUR into my GitHub windows folder, in the correct section ... the asterisk package is in the aur area of the ArchLinux ARM github repository. I can see the diff between the versions (the new version I downloaded from the AUR and the current version in the Arch github repository), next I think I committed it and hit sync. At this point I am not sure where the committed files went.

I'm pretty nervous about screwing something up and getting my ***** chewed out, but I am doing the best I can while trying to learn GitHub from scratch, how the AUR works, how the ARM team wants things and trying to motivate the maintainer of the asterisk package to make the necessary changes to things like dependencies, etc. so installation of asterisk is easier for Alarm users. It's all a bit overwhelming at this point, but I think I have made the correct updates.

I am not sure what I need to do next, but I would sure be thankful from some input back telling me if what I have done has been correct or not and what I need to do next to get the asterisk package correctly updated.
calzon65
 
Posts: 80
Joined: Wed May 25, 2011 9:06 pm

Re: Pull Request Question

Postby pepedog » Fri Jul 18, 2014 7:18 am

How many files edited? If one you could easily do it on the web
Where is your GitHub site?
pepedog
Developer
 
Posts: 2431
Joined: Mon Jun 07, 2010 3:30 pm
Location: London UK

Re: Pull Request Question

Postby calzon65 » Fri Jul 18, 2014 2:16 pm

Thank you for the response. I deleted the repository I created on my PC and started over. Reading through the GitHub documentation, I decided to fork a repository of the ArchLinux PKGBUILDs on GitHub's servers, not on my PC. Via my browser, I logged into my GitHub account, went into my repository, hosted on GitHub's servers, navigated to aur/asterisk and proceeded to update the asterisk PKGBUILD file by downloading the asterisk AUR tarball. I could see the diff from the PKGBUILD in my aur/asterisk repository and the ArchLinux repository. So finally I initiated a Pull Request, added my notes, and saw it created a Pull Request #906 in the ArchLinux ARM issue tracker.

Hopefully I did that all correctly. If there is an easier way, I would love to know it.
calzon65
 
Posts: 80
Joined: Wed May 25, 2011 9:06 pm

Re: Pull Request Question

Postby pepedog » Fri Jul 18, 2014 6:52 pm

This is exactly why I asked how many files changed, easy wasn't it?

If it was many, you use you linux device to git clone your own repo, edit what you want, cd PKGBUILDs, git add <each file edited or added>, git commit (look this one up), git push. Now you request the pull on web page.
Before all this you set up keys and password on your device, suggest you add user with same name as GitHub account.
You can practice but stop short at pull request.
pepedog
Developer
 
Posts: 2431
Joined: Mon Jun 07, 2010 3:30 pm
Location: London UK

Re: Pull Request Question

Postby calzon65 » Fri Jul 18, 2014 10:36 pm

Yes thank you, it was not too difficult once I started messing around with it.
calzon65
 
Posts: 80
Joined: Wed May 25, 2011 9:06 pm


Return to General

Who is online

Users browsing this forum: No registered users and 45 guests

cron