ODROID-C1: Wrong pkgver in kodi-c1 package

This forum is for topics dealing with problems with software specifically in the ARMv7h repo.

ODROID-C1: Wrong pkgver in kodi-c1 package

Postby Holzhaus » Sat Feb 14, 2015 2:42 pm

Hi,

The PKGBUILD of kodi-c1 states that it's version 14.0, but in facts it’s 15.0-ALPHA1 (that's at least what Kodi says in the "System Information" panel).

I opened a Github issue, but it was closed without comment.

Shall I send a pull request? Or am I totally wrong?

If not, i'd rather wait until the PKGBUILD get's updated anyway to fix this (as this is only a labeling issue and would waste unneccessary resources).

Thanks in advance,
Jan
Holzhaus
 
Posts: 62
Joined: Wed Jan 21, 2015 12:40 pm

Re: ODROID-C1: Wrong pkgver in kodi-c1 package

Postby moonman » Sat Feb 14, 2015 3:19 pm

The issue was likely closed because you didn't follow the guidelines (link highlighted at the top of New Issue windows): https://github.com/archlinuxarm/PKGBUIL ... IBUTING.md

I don't see why sending a pull request would be an issue.
Pogoplug V4 | GoFlex Home | Raspberry Pi 4 4GB | CuBox-i4 Pro | ClearFog | BeagleBone Black | Odroid U2 | Odroid C1 | Odroid XU4
-----------------------------------------------------------------------------------------------------------------------
[armv5] Updated U-Boot | [armv5] NAND Rescue System
moonman
Developer
 
Posts: 3388
Joined: Sat Jan 15, 2011 3:36 am

Re: ODROID-C1: Wrong pkgver in kodi-c1 package

Postby Holzhaus » Sat Feb 14, 2015 4:02 pm

$this->bbcode_second_pass_quote('moonman', 'T')he issue was likely closed because you didn't follow the guidelines (link highlighted at the top of New Issue windows): https://github.com/archlinuxarm/PKGBUIL ... IBUTING.md


Yikes, I must have overlooked that. Sorry! Thanks for pointing that out.

$this->bbcode_second_pass_quote('moonman', 'I') don't see why sending a pull request would be an issue.


Well, this adds no real values besides correcting the package version, but forces everyone who does "pacman -Syu" to redownload and reinstall kodi. Anyway, I'll write a PR.

Thanks again!
Holzhaus
 
Posts: 62
Joined: Wed Jan 21, 2015 12:40 pm

Re: ODROID-C1: Wrong pkgver in kodi-c1 package

Postby Holzhaus » Sat Feb 14, 2015 4:44 pm

There it is: #1097. I'll mark this as solved as soon as the PR has been merged.
Holzhaus
 
Posts: 62
Joined: Wed Jan 21, 2015 12:40 pm

Re: ODROID-C1: Wrong pkgver in kodi-c1 package

Postby Holzhaus » Sun Feb 15, 2015 10:39 am

kmihelich rejected my PR because "15.0alpha1" > "15.0". Any suggestions what pkgver to use instead? Just plain "15.0"?
Or probably "14.9.701", as seen in version.txt of Kodi?

Or like this:
$this->bbcode_second_pass_code('', '_kodiver=15.0.alpha1
pkgver=15.0
pkgrel=0.alpha1.1')

Thanks in advance,
Jan
Holzhaus
 
Posts: 62
Joined: Wed Jan 21, 2015 12:40 pm

Re: ODROID-C1: Wrong pkgver in kodi-c1 package

Postby Holzhaus » Sun Feb 15, 2015 2:31 pm

I chose the latter (because it's how the x86-ArchLinux-devs dealt with such a problem) and started a new PR: https://github.com/archlinuxarm/PKGBUILDs/pull/1102

I hope my PR is okay this time.
Holzhaus
 
Posts: 62
Joined: Wed Jan 21, 2015 12:40 pm

Re: ODROID-C1: Wrong pkgver in kodi-c1 package

Postby Holzhaus » Sun Feb 15, 2015 6:46 pm

Apparently not. Since it was closed without any comment, I suppose there's still something wrong with it (although I have no idea what it is). I don't want to annoy kmichelich, so I'll stop trying to fix this.
Holzhaus
 
Posts: 62
Joined: Wed Jan 21, 2015 12:40 pm

Re: ODROID-C1: Wrong pkgver in kodi-c1 package

Postby moonman » Sun Feb 15, 2015 8:32 pm

Yeah don't worry about it.
Pogoplug V4 | GoFlex Home | Raspberry Pi 4 4GB | CuBox-i4 Pro | ClearFog | BeagleBone Black | Odroid U2 | Odroid C1 | Odroid XU4
-----------------------------------------------------------------------------------------------------------------------
[armv5] Updated U-Boot | [armv5] NAND Rescue System
moonman
Developer
 
Posts: 3388
Joined: Sat Jan 15, 2011 3:36 am


Return to ARMv7h

Who is online

Users browsing this forum: No registered users and 16 guests