by summers » Wed Feb 13, 2019 10:38 am
@TheSaint - Thanks, So we can conclude that we need to pull both pins before we can start wi-fi and that io-domains must be enabled (set to okay). So thats seems to confirm all needed.
@lgb
1) White space! tell me about it - actually I've not had a problem with my code in the past, just nighmares pasting it into emails or on the web, both replace tabs which is kernel preferred. These days I just use the git commands to send emails with patches, the command line is complicated and a real brain stain, but the patches are ones that the kernel maintainers will accept ...
2) So you mean do:$this->bbcode_second_pass_code('', ' @@ -96,6 +97,15 @@
startup-delay-us = <100000>;
vin-supply = <&vcc_io>;
};
+
+ sdio_pwrseq: sdio-pwrseq {
+ compatible = "mmc-pwrseq-simple";
+ clocks = <&rk808 RK808_CLKOUT1>;
+ clock-names = "ext_clock";
+ pinctrl-names = "default";
+ pinctrl-0 = <&wifi_enable>;
+ reset-gpios = <&gpio4 RK_PD3 GPIO_ACTIVE_LOW>, <&gpio4 RK_PD4 GPIO_ACTIVE_LOW>;
+ };
};
@@ -415,6 +425,16 @@
rockchip,pins = <7 8 RK_FUNC_GPIO &pcfg_pull_none>;
};
};
+
+ wifi_enable: wifi-enable {
+ rockchip,pins = <4 RK_PD3 RK_FUNC_GPIO &pcfg_pull_none>, <4 RK_PD4 RK_FUNC_GPIO &pcfg_pull_none>;
+ };
+ };
};
')
Yes I can see that would make sense, if we knew that at times we only have to pull one pin then maybe keep seperate. But as we have little knowledge of what these pins are connected to, and just guess (e.g. the schematics don't help) - yes might as well merge.
3) disable-wp is in the current mainline device tree - I'll review today as to if we take out- and make sure we get it tested on TheSaints machine. Question is what does write protection mean for a microSD card? It has no switch - so what is the preferred. Guess we need to know this before working out what the tinker board is wired up. And as usual the schematic doesn't help - it doesn't show the connection to the sd Card ...
4) Yes I been thinking about splitting, wi-fi, bluetooth, sdcard. Hassle is all are changes to the same file, so will depend on order applied. Anyway yes I'll split as it makes reviewing easier.
5) I'll try and work out a suitable comment ...